BudgetAirpods / InsanityRemastered

A mod for Lethal Company that adds more features to the insanity mechanic.
4 stars 3 forks source link

Disabled items appearing as illusions. #4

Open Clark919 opened 7 months ago

Clark919 commented 7 months ago

As the title suggests. Say I have a mod like LethalThings installed and disable one of their items as a naturally spawning item. Whenever I have an illusion of a fake item, this still might appear on the ground.

BudgetAirpods commented 7 months ago

I'm assuming that this is a suggestion rather than a bug report. If it's a bug report please do correct me.

As of now, the way the fake item spawning works is it gets the current moon's spawnable scrap, meaning if LethalThings adds it to the moon's spawnable scrap list, it most likely already does this. I will test it myself however.

Will keep you updated.

Clark919 commented 7 months ago

It's somewhat both? As far as I'm concerned if a modded item is disabled for spawning as a scrap item, it shouldn't appear as an illusion, but imagine your mod pulls any scrap item from the list of loaded scrap in the registry to create an illusion.

To clarify further if I'm not being clear: the LethalThings mod has a toy revolver as a modded scrap item. If I set the spawn weight of this particular item in their config to 0, it will not appear at all during standard gameplay. However, with InsanityRemastered installed, there is a chance the item appears as an illusion anyway, which makes it insanely obvious it's not real and sort of breaks away from the experience by readding content you've made sure to disable.

Clark919 commented 7 months ago

Another thing maybe worth adding (not sure if this is a design choice) is Illusions never have a value, making them very easy to recognise and avoid. My suggestion would be to have their value generate as a number outside of what they'd normally generate as (as an example, say an engine is worth 25-70, have the illusions always generate the value as either under 25 or greater than 70 so people who are familiar with the values have reason to suspect something is wrong).

BudgetAirpods commented 7 months ago

I see what you mean now. I apologize for my confusion. I will actually look into doing something about spawning fake items that aren't enabled through mods (or if some mod disables spawning vanilla items).

As for the second suggestion: I originally wanted to actually have this in, but I could not for the life of me figure out how to set the value of the scrap; so, I just played it off as "Hey, this scrap doesn't have value. Something seems off here." I'm probably just very stupid and it's actually very easy, but I'll have this in the next update.

Again, I am sorry for my confusion. Thank you for clarifying.

Clark919 commented 7 months ago

I see what you mean now. I apologize for my confusion. I will actually look into doing something about spawning fake items that aren't enabled through mods (or if some mod disables spawning vanilla items).

As for the second suggestion: I originally wanted to actually have this in, but I could not for the life of me figure out how to set the value of the scrap; so, I just played it off as "Hey, this scrap doesn't have value. Something seems off here." I'm probably just very stupid and it's actually very easy, but I'll have this in the next update.

Again, I am sorry for my confusion. Thank you for clarifying.

Ah it's all good, I wasn't insanely clear on my last message. If you do manage to achieve something like this that'd be quite ideal! Thanks for the cool mod anyways, it's nice to see someone do something interesting with this mechanic :]