search

BudgetSquirrel / BudgetTracker

Budget Tracker allows users to manage their money more efficiently. This API has endpoint to save, create, and manage your budgets and goals.
4 stars 0 forks source link

Task/45 update budget #49

Closed BenjaminGroseclose closed 5 years ago

BenjaminGroseclose commented 5 years ago

@ianbro updated the converters and the request name

BenjaminGroseclose commented 5 years ago

@ianbro Think you might have pushed an error. Looks like in the BudgetRepo there is an error casting from BudgetDurationBase to BudgetDurationModel

ianmann56 commented 5 years ago

Is it a build error? Master is building fine for me. Where is the error?

BenjaminGroseclose commented 5 years ago

@ianbro If you could pull down this branch and fix the BudgetDuration issue.

BenjaminGroseclose commented 5 years ago

Looks like it is related to my new Update budget request contract and your new budget duration contract

ianmann56 commented 5 years ago

Lol yeah you just never implemented my change in model for duration. I'm making the necessary changes to get it working.

ianmann56 commented 5 years ago

OK, I just fixed the build errors. There's some logic I'mma let you finish though since it's your PR. The UpdateBudgetRequestContract has to accept either a MonthlyDaySpanBudgetDurationContract or a MonthlyBookEndedBudgetDurationContract. Look how I do it in the CreateBudgetRequestContract and that converter.

Also, keep in mind, make sure the user can change the duration from a MonthlyDaysSpanDuration to a MonthlyBookEndedDuration and vice versa. Ask me if you have questions. It gets kind of complicated.

BenjaminGroseclose commented 5 years ago

@ianbro something like that?

ianmann56 commented 5 years ago

Yes!

BenjaminGroseclose commented 5 years ago

@ianbro I have lost track anything else I need to do before I merge

ianmann56 commented 5 years ago

lol

BenjaminGroseclose commented 5 years ago

Haha thanks sorry lost track updating it now!