Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
22.47k stars 1.55k forks source link

budi hosting --init doesn't check for Docker with Compose plugin #11982

Closed IvanDrag0 closed 1 year ago

IvanDrag0 commented 1 year ago

Currently, when using the Budibase CLI and running budi hosting --init, the program checks to make sure that Docker and docker-compose are installed. If one of them is missing, the program errors out. Based on the checkDockerConfigured() function in utils.ts, it looks like the app is checking for the presence of the docker and docker-compose programs.

export async function checkDockerConfigured() {
  const error =
    "docker/docker-compose has not been installed, please follow instructions at: https://docs.budibase.com/docs/docker-compose"
  const docker = await lookpath("docker")
  const compose = await lookpath("docker-compose")
  if (!docker || !compose) {
    throw error
  }
}

However, the program doesn't check for the Compose plugin (which is the preferred method over using docker-compose). The function should be edited to check whether the Compose plugin is being used as well.

mike12345567 commented 1 year ago

This should be resolved now.