Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
22.47k stars 1.55k forks source link

After upgrading from 2.12.2 to 2.13.28, signature field validation fails #12484

Closed dp12 closed 10 months ago

dp12 commented 10 months ago

Checklist

Hosting

Describe the bug Using the https://github.com/FlaminWrap/budibase-signature-component plugin used to be validated correctly in a form for version 2.12.2, added by setting Validation -> Add Rule -> Required for the signature field. Now in version 2.13.28, it is not validated at all, so the form user can ignore the signature field and submit a form without drawing a signature.

To Reproduce Steps to reproduce the behavior:

  1. Create an app with a Form component
  2. Add a text field and signature field to the component
  3. Set both fields to be required through Validation -> Add Rule -> Required
  4. Add a save button with Validate Form as the first action
  5. Preview or Publish the app
  6. Fill in the text field and leave the signature field empty
  7. Click the save button, which will submit the form without validating the signature field

Expected behavior The signature field should display the error message from Validation Rules and the form should not be successfully validated

Additional context The signature plugin version is v1.3.0 (latest)

melohagan commented 10 months ago

Hey @dp12

Thanks for the reproduction steps! You don't actually need the text field to reproduce: Screenshot 2023-12-01 at 10 20 39

As this is an issue with a plugin, I am going to close the issue as we don't support plugins.

With that said, it is a great custom plugin so I do recommend that you raise this issue against the plugin Github repo!