Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.92k stars 1.52k forks source link

New table validation errors are not displayed to users #13894

Closed aptkingston closed 3 months ago

aptkingston commented 3 months ago

Describe the bug New validation errors relating to required fields are not displayed to the user, making it very difficult to work out why things aren't working. I think these were introduced as part of the readonly column work, but I'm not sure. I've just pulled the latest master and couldn't work out why no schema mutations were working. I then realised that the API calls were failing with errors similar to To make field "Cost" required, this field must be present and writable in views: gdfg.

This affected a few of my existing tables so I'm sure other users will be affected too. We just need to surface these new errors to users so they understand what the problems are and can fix them.

Since you were allowed to get into this state previously, but now we block all changes to schema in this state, I would consider this a breaking change since it requires manual intervention to restore functionality to your tables. I think it would have been better to either migrate this automatically for users or grandfather in existing tables with errors so that they continued to work.

I'm already working on a bunch of fixes so will add in a change to surface these errors.

linear[bot] commented 3 months ago

BUDI-8333 New table validation errors are not displayed to users