Closed Ghrehh closed 2 weeks ago
@deanhannigan @aptkingston I get what you guys mean, but for my money, the blinking cursor and change to the field upon highlight should be indication enough that the field is selected, it'd be more obvious if we used any sort of outline
upon focusing an input, but I think we have them all manually disabled.
The main reason I thought it'd be nice to have the context menu option is that despite there being a hover state for the input now, it's still hidden by default. Currently on master, I can easily imagine a user clicking around trying to figure out how to rename a component, and basically going "there's no field for this, there's a field for everything else but not this. You mustn't be able to rename a component". This is kind of exacerbated, imo, by the Screen
settings panel looking stylistically the same as the component one, but actually having a field to rename it.
But I'm happy to remove the context menu change, I realise this isn't even a requested change, I don't think anyone's even complained about it. So maybe I'm making a mountain out of a molehill 😆 I'll push up a commit now.
Description
We discussed in the avalanche standup this week that it wasn't immediately obvious to a user how to edit the name of a component, this PR makes some changes that will hopefully make it more intuitive.
Changes
text
cursor, which is the one normally shown for inputs.Notes
mod+g
which is a little strange, but every letter inrename
is a fairly major OS/browser level hotkey a user might be upset if we override (at least on Mac).