Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.23k stars 1.43k forks source link

UX Changes to Component Name Editing Flow #13921

Closed Ghrehh closed 2 weeks ago

Ghrehh commented 3 weeks ago

Description

We discussed in the avalanche standup this week that it wasn't immediately obvious to a user how to edit the name of a component, this PR makes some changes that will hopefully make it more intuitive.

Changes

Notes

Info Screenshot
Context menu Screenshot 2024-06-12 at 09 08 35
Editing Screenshot 2024-06-12 at 09 08 41
Clicking directly Jun-12-2024 09-09-53
Ghrehh commented 2 weeks ago

@deanhannigan @aptkingston I get what you guys mean, but for my money, the blinking cursor and change to the field upon highlight should be indication enough that the field is selected, it'd be more obvious if we used any sort of outline upon focusing an input, but I think we have them all manually disabled.

The main reason I thought it'd be nice to have the context menu option is that despite there being a hover state for the input now, it's still hidden by default. Currently on master, I can easily imagine a user clicking around trying to figure out how to rename a component, and basically going "there's no field for this, there's a field for everything else but not this. You mustn't be able to rename a component". This is kind of exacerbated, imo, by the Screen settings panel looking stylistically the same as the component one, but actually having a field to rename it.

But I'm happy to remove the context menu change, I realise this isn't even a requested change, I don't think anyone's even complained about it. So maybe I'm making a mountain out of a molehill 😆 I'll push up a commit now.