search

Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.23k stars 1.43k forks source link

Test in-memory search alongside all of our other search types, to ensure parity. #13941

Closed samwho closed 2 weeks ago

samwho commented 2 weeks ago

Description

This PR makes sure that our in-memory searching that we use in the frontend behaves the same as the backend searches by plugging them into the same test suite the backend ones use.

linear[bot] commented 2 weeks ago

BUDI-8349 In-memory search parity testing

github-actions[bot] commented 2 weeks ago

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] commented 2 weeks ago

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] commented 2 weeks ago

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] commented 2 weeks ago

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] commented 2 weeks ago

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

aptkingston commented 2 weeks ago

Any idea if this PR would address https://github.com/Budibase/budibase/issues/13505#issuecomment-2060860157? I had noticed before we didn't properly support the "match any" function in the in-memory filtering.

samwho commented 2 weeks ago

@aptkingston Yes, I think it probably will. There was a bug in the way that the in-memory filter did matching where it wasn't correctly obeying the allOr param and I fixed that in this PR and I think what you describe in that comment would be fixed by what I did.

aptkingston commented 2 weeks ago

@aptkingston Yes, I think it probably will. There was a bug in the way that the in-memory filter did matching where it wasn't correctly obeying the allOr param and I fixed that in this PR and I think what you describe in that comment would be fixed by what I did.

Super! Thanks.