search

Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.23k stars 1.43k forks source link

Remove deprecated properties #13958

Closed melohagan closed 1 week ago

melohagan commented 2 weeks ago

Description

Need to remove these properties so that I can avoid using this type in account-portal

Addresses

linear[bot] commented 2 weeks ago

GROW-472 Remove use of types package in account-portal

samwho commented 1 week ago

https://github.com/Budibase/budibase/pull/13958/commits/943a6199b12cda4aca2f6cc94a723610a116b0c8

This seems like a fairly large change, is this something that we've discussed wider and agreed on?

melohagan commented 1 week ago

943a619

This seems like a fairly large change, is this something that we've discussed wider and agreed on?

No it hasn't been. I've been trying to detangle the types between Budibase core and account-portal.

What I can do is merge this in to remove the tier property, update account-portal to no longer use this property, and then re-add the account-portal tests run back into the Budibase core CI again?