Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.92k stars 1.52k forks source link

Fix NX hiding test failures #14068

Closed adrinr closed 3 months ago

adrinr commented 3 months ago

Description

We found an issue with lerna while combining the flags --since and --scope. For example, running the command yarn test --scope=@budibase/worker --since=master, with changes only on @budibase/backend-core will not work as expected, as it does not analyse the dependencies properly. The actual @budibase/worker task will not be triggered.

We are now using a new script, that runs lerna ls to detect all the affected projects from a given commit, and if the scoped package is affected, the actual command will be executed.

The other usages on pipelines are not affected, as the flag --ignore behaves as expected.

On the process, I updated lerna to the latest 7.x

Addresses

linear[bot] commented 3 months ago

BUDI-8408 NX affected by - hiding test failures