Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.78k stars 1.49k forks source link

Change the rendering of the disabled setting for buttons inside the table component. #14380

Open mikesealey opened 4 weeks ago

mikesealey commented 4 weeks ago

Checklist

Hosting

Describe the bug Setting a button to disabled in a table does not disable the button

To Reproduce Steps to reproduce the behavior:

  1. Add a Table component
  2. Add a button to display a notification
  3. In the button settings, check "Disabled"
  4. Pulish and click the button

Expected behavior Disabling a button should change it's appearance and prevent it's funcitonality

Screenshots JAM - https://jam.dev/c/a386a4e6-1e84-4f85-b076-156524a1bde4

App Export Table Component Buttons-export-1723648046868.tar.gz

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

linear[bot] commented 4 weeks ago

BUDI-8569 Table Buttons set to disabled are still enabled

mikesealey commented 4 weeks ago

Bonus feature request: Could we have Conditions to Update Settings for buttons in tables? Update button to be disabled if (value in row = 0)

aptkingston commented 4 weeks ago

This is a known limitation I'm afraid and I think there was a ticket for it before. There are a few settings that don't have any effect for table buttons (size is another example). This is deliberate on one hand so that we can ensure that buttons actually look correct and work properly in tables, but it's also just a side effect of how we render the settings at the moment. I would flag this as an enhancement to find a different way of rendering component settings so that they can be conditional on use case.