Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.88k stars 1.51k forks source link

Minor ui issue with the table component, adding a button causes an extra space to appear at the bottom. #14481

Open ConorWebb96 opened 3 weeks ago

ConorWebb96 commented 3 weeks ago

Checklist

Hosting

Describe the bug When adding buttons to the table component. if the add row setting is toggled off and a button is added, an empty box is shown at the very bottom of the table which looks very out of place.

To Reproduce Steps to reproduce the behavior:

  1. Add a table component
  2. Add a button
  3. Make sure the add rows setting is toggled off
  4. Scroll to the bottom
  5. Notice strange button box, looks somewhat out of place

Expected behavior If there is no button then this additional button outline shouldn't appear.

Screenshots

Screenshot 2024-08-30 at 12 18 43 Screenshot 2024-08-30 at 12 19 09
linear[bot] commented 3 weeks ago

BUDI-8600 Minor ui issue with the table component, adding a button causes an extra space to appear at the bottom.

aptkingston commented 3 weeks ago

Just to clarify - an important part of the reproduction steps here is disabling the "add rows" setting. This only happens when you add buttons and disable adding rows.

ConorWebb96 commented 3 weeks ago

The box is added regardless of the add row setting. It looks better when checked though. I do think the last box should be removed as there is nothing there.

Screenshot 2024-08-30 at 13 08 54 Screenshot 2024-08-30 at 13 09 16

What I think it maybe should look like?

Screenshot 2024-08-30 at 13 10 58
aptkingston commented 3 weeks ago

It's supposed to be there when adding rows though, to keep consistency when scrolling. I did test it both ways when adding it, and having all columns have the same render space looks better than having the "new row" section extend further.

So I just mean that the issue of having the floating box only appears when disabling adding rows.