Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
22.72k stars 1.57k forks source link

Navigation items when they have parameters attached don't highlight as active when on the relevant page. #14528

Open ConorWebb96 opened 2 months ago

ConorWebb96 commented 2 months ago

Checklist

Hosting

Describe the bug When a param is added to a navigation link activate state of the navigation item no longer works. I'm assuming a check is being done to get the exact match rather than ignoring the params when viewing the page.

To Reproduce Steps to reproduce the behavior:

  1. Create a new app
  2. Create 2 different links one without a param on the end and one with ?mode=readonly
  3. Publish and navigate between the two screens
  4. See that the one that has the param on the end doesn't have an active state when on its own page.

Expected behavior Active state should work even if there are params on the end of the navigation link.

Screenshots 20240905_125742

Additional context Related discussion

linear[bot] commented 2 months ago

BUDI-8627 Navigation items when they have parameters attached don't highlight as active when on the relevant page.