Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.84k stars 1.5k forks source link

Two JS Scripting Steps can have the same name and their bindings display together #14615

Open mikesealey opened 2 hours ago

mikesealey commented 2 hours ago

Checklist

Hosting

Describe the bug When creating an automation with multiple JS Scripting steps it is possible to change the names of the scripting blocks so that they match. When the names match, both sets of "Success (boolean)" and "Value(text)" appear in the bindings drawer under the JS Scripting Block of that name.

To Reproduce Steps to reproduce the behavior:

  1. Create an automation
  2. add 3 JS Scripting Blocks
  3. Change the name of the second JS Scripting Block to match the first (remove the "2")
  4. Edit the code of the third JS Scripting block
  5. open the bindings drawer to see a single JS Scripting Block available
  6. Enter that JS Scripting Block and see Duplicates of Success+Value

**Note: It is not possible to have a third JS Scripting Block of the same name through this process.

Expected behaviour If only the names are being used to identify the JS Scripting blocks, they should be unique.

Screenshots JAM: https://jam.dev/c/259c5cdb-e2f8-4cf0-8d19-56d5f37937b0

App Export Venu Automations-export-1726837313634.tar.gz

Desktop (please complete the following information):

Additional context Issue was discovered while investigating something for a customer.

linear[bot] commented 2 hours ago

BUDI-8661 Two JS Scripting Steps can have the same name and their bindings display together