Only check visible fields when checking group by view calculations.

Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀

https://budibase.com

Other

22.75k stars 1.57k forks source link

Only check visible fields when checking group by view calculations. #14753

Closed samwho closed 1 month ago

samwho commented 1 month ago

Description

@aptkingston pointed out my recently added validation against complex types in group-by fields includes fields that are visible: false. Because we enrich views after creation and includes all fields in their schema, this meant that this validation failed whenever the table contained a complex field, visible or not.

qa-wolf[bot] commented 1 month ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!