search

Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
22.79k stars 1.58k forks source link

Role validation - allow permissionId to be optional #14853

Closed mike12345567 closed 1 month ago

mike12345567 commented 1 month ago

Description

Frontend now expects to be able to supply role without a permissionId, this update makes it so that the validators allow this.

Added test cases for the behaviour - also realised the types in this area were pretty incorrect based on the validators, permissionId was just a string when it was actually typed, fixed this.

qa-wolf[bot] commented 1 month ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!