Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
21.85k stars 1.5k forks source link

Only show automation log filters relevant to the BB pricing plan you are on #6675

Closed joebudi closed 1 year ago

joebudi commented 2 years ago

When I'm viewing automation logs, I only want to have access to the time based filters that are relevant to me - for example 24h on free, 7days on premium etc, so that I can be sure that I am viewing the full history of my logs that my plan allows.

COS

Original Context

I have a CRON trigger that shoots our an email automation every morning at 8am. It was a success yesterday: CleanShot 2022-07-12 at 12 41 21

And it was a success today:

CleanShot 2022-07-13 at 09 17 50@2x

But shouldn't the logs show both events? I can't see yesterday's automation event.

shogunpurple commented 2 years ago

This is because the automation history by default is 24h - your log line was over a day ago.

Converting this issue to an enhancement to only show the relevant filters based on the plan you are on

deanhannigan commented 2 years ago

Hey @joebudi, We could definitely add in the disabled option behaviour as a global change to the Select component but the clickable labels might prove tricky to pull off.

Instead, the upgrade messaging could be approached at the table level, e.g:

automations_upgrade

Does that seem like a decent compromise?

joebudi commented 2 years ago

Would it be possible to have the labels (disabled option) if it wasn't clickable?

AndyWhann commented 2 years ago

@joebudi We don't store anything past 24 hours for free plan and showing the disabled options in the dropdown as suggested I.M.O looks like we are saying "We have your past 30 days, upgrade to get access" but we don't store it.

Once you upgrade we only begin to start tracking past 24 hours.

joebudi commented 2 years ago

Maybe include a tooltip saying, "Once you upgrade, we will start tracking logs for up to X days."?

aptkingston commented 2 years ago

From a dev perspective, I'd prefer to avoid putting any sort of pro-specific logic inside components. We need to keep the components as generic as possible. We can show the options and disable them since that's generic, but a "pro" badge or tooltips inside the dropdown would be tricky to do in a clean way.

shogunpurple commented 2 years ago

Think the easiest solution here is:

joebudi commented 2 years ago

The "pro" badge will become more important as we add more pro features. It's an important way to educate users about the additional functionality available on the premium tiers. It will need to be done eventually.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity.