Budschie / BudschieMorphMod

This is a port of the morph mod to forge 1.16.5
MIT License
11 stars 9 forks source link

Fresh Animations Resource Pack Bug / Glitch #49

Open AFinalWord opened 2 years ago

AFinalWord commented 2 years ago

I don't know if this is something you would try and fix, but I really like using the Fresh Animations resource pack since it's really cool, but whenever I use it with this mod, the animations on the mob morphs don't work, the animation either is just frozen to whatever the idle is, or just a random animation, (Such as the chickens falling animation) so if it's possible it would be cool to give the morphs the animations, again though I don't know if this is a thing you would look into and think it would be pointless or not since it's something from a different person and creator and might not be worth your time getting into.

I think I found what the problem is, whatever position the player is in, it freezes your movement to whatever it is as that morph, for example: image image image image image

https://user-images.githubusercontent.com/94770604/145682759-60649b78-9691-4bef-942f-32a47ed0d7ab.mov

And another thing to note, some of the animations do sort of work, when you jump with the chicken, the chickens wing flapping animations actually works! When you touch the ground again though, it freezes to whatever it was before. I think the problem for this is that they might have renamed some of the axis and animations, I've done custom entity modeling in OptiFine before, and I think the files might have different names maybe? Because some of the animations do technically work like the chicken's flapping animation, so that one might not have been changed with the name, but yeah that's just what I think, it might not actually be true, but it does use OptiFine custom entity models, so it might be true. I don't know.

Also, in case you don't know what the Fresh Animations resource pack is, it basically gives animations to most of the mobs in the game, it looks a lot similar to the Minecraft trailers, here is the link: https://www.curseforge.com/minecraft/texture-packs/fresh-animations

Budschie commented 2 years ago

So, the issue probably is that I don't call the tick method of morphs, but that's entirely intentional. If I were to call the tick method, the morph would not only update its animations, but also a whole range of other things, which could potentially lead to blocks being destroyed on the client when they aren't destroyed on the server.

This means that there's not a whole lot that I can do; OptiFine is closed-source, which means that I can't really add compatibility patches for OF's animations in my mod or in OF itself.

If you know an open source mod that allows you to read OF entity animations and resource packs, please tell me, because then I could patch my mod to be compatible with this really nice resource pack.

With that said, I hope that this reply isn't disappointing to you or anything. - Budschie

AFinalWord commented 2 years ago

Man, that sucks, I'll try and see if there are any, but I doubt there's a mod for that, thanks anyways for explaining this to me though, have a nice day.