BugSplat-Git / symbol-upload

Cross-platform symbol upload utility
MIT License
10 stars 3 forks source link

fix: don't fire uploads promises all at once #123

Closed bobbyg603 closed 4 months ago

bobbyg603 commented 4 months ago

For large file lists we're firing off like 40000 promises at once. Node's async I/O is supposed to handle this, but it seems like at these numbers everything falls apart. We open hundreds of file descriptors, and requests start to fail because we're absolutely hammering the backend and perhaps even overwhelming the sending machine. This change awaits each upload requests so there's at most 16 going simultaneously instead of an indeterminate amount.