BugSplat-Git / symbol-upload

Cross-platform symbol upload utility
MIT License
10 stars 3 forks source link

Error: ENOTEMPTY: directory not empty, rmdir 'C:\[...]\tmp' #60

Closed jasonsketchup closed 1 year ago

jasonsketchup commented 1 year ago

Using symbol-upload-win.exe w/ MD5 sum f700cb844fa5e230febcf0122b5e97e0, should be the latest release. Seeing intermittent errors...

build   27-Sep-2023 17:21:01    INFO     - Uploading files to BugSplat... Calling: ['c:/[...]/symbol-upload-win.exe', '--threads', '16', [...], '--files', '*.*']
[...]
error   27-Sep-2023 17:21:22    Error: Error uploading to presigned URL https://bugsplat-symbols.s3-external-1.amazonaws.com/[...]
error   27-Sep-2023 17:21:22        at S3ApiClient.<anonymous> (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:61:35)
error   27-Sep-2023 17:21:22        at step (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:33:23)
error   27-Sep-2023 17:21:22        at Object.next (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:14:53)
error   27-Sep-2023 17:21:22        at fulfilled (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:5:58)
error   27-Sep-2023 17:21:22        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
error   27-Sep-2023 17:21:22    Could not delete C:\[...]\tmp! [Error: ENOTEMPTY: directory not empty, rmdir 'C:\[...]\tmp'] {
error   27-Sep-2023 17:21:22      errno: -4051,
error   27-Sep-2023 17:21:22      code: 'ENOTEMPTY',
error   27-Sep-2023 17:21:22      syscall: 'rmdir',
error   27-Sep-2023 17:21:22      path: 'C:\\[...]\\tmp'
error   27-Sep-2023 17:21:22    }

console.log

jasonsketchup commented 1 year ago

Also seeing...

build   27-Sep-2023 18:25:36    node:internal/errors:477
build   27-Sep-2023 18:25:36        ErrorCaptureStackTrace(err);
build   27-Sep-2023 18:25:36        ^
build   27-Sep-2023 18:25:36    TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
build   27-Sep-2023 18:25:36        at new NodeError (node:internal/errors:388:5)
build   27-Sep-2023 18:25:36        at ReadableStreamDefaultController.close (node:internal/webstreams/readablestream:985:13)
build   27-Sep-2023 18:25:36        at node:internal/deps/undici/undici:923:26
build   27-Sep-2023 18:25:36        at node:internal/process/task_queues:140:7
build   27-Sep-2023 18:25:36        at AsyncResource.runInAsyncScope (node:async_hooks:203:9)
build   27-Sep-2023 18:25:36        at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
build   27-Sep-2023 18:25:36        at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
build   27-Sep-2023 18:25:36      code: 'ERR_INVALID_STATE'
build   27-Sep-2023 18:25:36    }
build   27-Sep-2023 18:25:36    Node.js v18.5.0
bobbyg603 commented 1 year ago

Thanks for reporting these issues @jasonsketchup, I’ll investigate these asap.

bobbyg603 commented 1 year ago

Also seeing...

build 27-Sep-2023 18:25:36    node:internal/errors:477
build 27-Sep-2023 18:25:36        ErrorCaptureStackTrace(err);
build 27-Sep-2023 18:25:36        ^
build 27-Sep-2023 18:25:36    TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
build 27-Sep-2023 18:25:36        at new NodeError (node:internal/errors:388:5)
build 27-Sep-2023 18:25:36        at ReadableStreamDefaultController.close (node:internal/webstreams/readablestream:985:13)
build 27-Sep-2023 18:25:36        at node:internal/deps/undici/undici:923:26
build 27-Sep-2023 18:25:36        at node:internal/process/task_queues:140:7
build 27-Sep-2023 18:25:36        at AsyncResource.runInAsyncScope (node:async_hooks:203:9)
build 27-Sep-2023 18:25:36        at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
build 27-Sep-2023 18:25:36        at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
build 27-Sep-2023 18:25:36      code: 'ERR_INVALID_STATE'
build 27-Sep-2023 18:25:36    }
build 27-Sep-2023 18:25:36    Node.js v18.5.0

Moved to #61

bobbyg603 commented 1 year ago

Using symbol-upload-win.exe w/ MD5 sum f700cb844fa5e230febcf0122b5e97e0, should be the latest release. Seeing intermittent errors...

build 27-Sep-2023 17:21:01    INFO     - Uploading files to BugSplat... Calling: ['c:/[...]/symbol-upload-win.exe', '--threads', '16', [...], '--files', '*.*']
[...]
error 27-Sep-2023 17:21:22    Error: Error uploading to presigned URL https://bugsplat-symbols.s3-external-1.amazonaws.com/[...]
error 27-Sep-2023 17:21:22        at S3ApiClient.<anonymous> (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:61:35)
error 27-Sep-2023 17:21:22        at step (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:33:23)
error 27-Sep-2023 17:21:22        at Object.next (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:14:53)
error 27-Sep-2023 17:21:22        at fulfilled (C:\snapshot\symbol-upload\node_modules\@bugsplat\js-api-client\dist\cjs\common\client\s3-api-client\s3-api-client.js:5:58)
error 27-Sep-2023 17:21:22        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
error 27-Sep-2023 17:21:22    Could not delete C:\[...]\tmp! [Error: ENOTEMPTY: directory not empty, rmdir 'C:\[...]\tmp'] {
error 27-Sep-2023 17:21:22      errno: -4051,
error 27-Sep-2023 17:21:22      code: 'ENOTEMPTY',
error 27-Sep-2023 17:21:22      syscall: 'rmdir',
error 27-Sep-2023 17:21:22      path: 'C:\\[...]\\tmp'
error 27-Sep-2023 17:21:22    }

console.log

There are 2 separate issues here:

  1. The upload fails and needs to be retried
  2. The upload fails, the handle on the tmp file is (likely) open, cleanup fails, and needs to be retried
bobbyg603 commented 1 year ago

There are 2 separate issues here:

  1. The upload fails and needs to be retried
  2. The upload fails, the handle on the tmp file is (likely) open, cleanup fails, and needs to be retried

Moved 1 to #62

jasonsketchup commented 1 year ago

Thanks, @bobbyg603! Adding the new binaries to our automation now.