search

BuggleInc / webPLM

Web Interface of the PLM (JavaScript + Play framework)
https://plm.telecomnancy.univ-lorraine.fr
GNU Affero General Public License v3.0
11 stars 14 forks source link

No availaible OAuth method with firefox #88

Closed PLMbugz closed 8 years ago

PLMbugz commented 8 years ago

With that navigator (version 44, debian testing), I get a page with the text but no icon. It works fine in chromium.

Thanks, Mt.

MatthieuNICOLAS commented 8 years ago

To which page were you referring? https://plm.telecomnancy.univ-lorraine.fr/#/ui/signIn ? I could not reproduce your issue, neither with Firefox 45.0 nor Firefox Developer Edition 47.0a2

mquinson commented 8 years ago

Yes, this is the page I am referring to. If it works with any other versions of FF, then I guess we can live with it. We could also rephrase it to offer directly the login/password of our own OAuth provider, and add the buttons to the external services below. Something similar to what the Khan Academy proposes: capture-auth-khan

mquinson commented 8 years ago

For the record, the problem was due to my adblocker, which cut the script : https://plm.telecomnancy.univ-lorraine.fr/assets/app/components/sign-in/social-buttons.directive.js

The solution would probably to rename that script, or to add a hint at the bottom advising to people not seeing anything to turn their ad blocker off.

mquinson commented 8 years ago

This is now fixed, thanks for that.