search

BugiDev / react-native-calendar-strip

Easy to use and visually stunning calendar component for React Native.
MIT License
953 stars 328 forks source link

Invalid prop `controlDate` #140

Closed v-stickykeys closed 4 years ago

v-stickykeys commented 5 years ago

The controlDate propType is currently set to PropTypes.object

The documentation states in should PropTypes.any and based on how it is used (it expects a string so it can be converted to a moment date) it should be any or string.

I don't think this bug breaks anything but its a quick fix and saves a warning.

peacechen commented 5 years ago

Thanks @valmack for noticing this. I pushed your suggested fix and will be included in the next release.