search

BugiDev / react-native-calendar-strip

Easy to use and visually stunning calendar component for React Native.
MIT License
939 stars 327 forks source link

Bug with scrollable prop active on iOS devices #192

Closed caiobiodere closed 4 years ago

caiobiodere commented 4 years ago

there is a bug that seems to be happening only on iOS devices, while scrolling I could see the label blinking and almost like it is disappearing from the container view. Is there any workaround/solution available to get this working properly? simulator

peacechen commented 4 years ago

I've observed that on an iPad as well. Which device(s) did you test on?

This library uses RecyclerListView to implement the bidirectional infinite scroller. RecyclerListView works by recycling components from the non-visible end to the visible end that the scroller moves toward. The shifts should be instantaneous and invisible, but there's a bug or limitation in RecyclerListView. If you have time, it would be of great help to try to debug that in RecyclerListView.

caiobiodere commented 4 years ago

I was testing on an iPhone 11 but could see the problem happening in any iOS devices, because I am using this plugin in a company project might be worth trying to fix this problem will see what I can do mate.

caiobiodere commented 4 years ago

@peacechen hey mate I found what was happening, it was a small thing just because it wasn't checking if scrollable prop was either active or not it was still creating and updating day selection animation on componentDidUpdate method, could you please approve this pull request: https://github.com/BugiDev/react-native-calendar-strip/pull/193

peacechen commented 4 years ago

Great detective work @caiobiodere 👍 Your help is much appreciated.

The fix has been published in 2.0.3