search

BugiDev / react-native-calendar-strip

Easy to use and visually stunning calendar component for React Native.
MIT License
936 stars 325 forks source link

Fix linting error #243

Closed sugersuger closed 3 years ago

sugersuger commented 3 years ago

In this PR, we supported externalScrollView prop to replace ScrollView with something else.

It's very useful, but RecyclerListView has many TypeScript-errors. Therefore, we have TypeScript linting-error again.

We can't fix those errors directly.
So I skip the Library's type-check by adding a file tsconfig.json.

And I add some necessary Declaration Files.

peacechen commented 3 years ago

Thanks @sugersuger Is this ready to be published?

sugersuger commented 3 years ago

In my opinion, we might want to more check the index.d.ts file in our project over for potential TypeScript-problems before publishing.
This PR only fix compile-errors if we run the $ tsc command in our project's root directory.

For example, if this branch is merged and the user uses this package, the user may see a type-problem.
image

I didn't change the ReactNativeCalendarStrip class's type annotation anything.
Perhaps the error has potentially been in our project.

peacechen commented 3 years ago

Another PR has been in the pipeline waiting to be published. Is there a quick way to resolve the TS definition errors?

sugersuger commented 3 years ago

@peacechen I fix the TS definition errors.
Anyhow, this revision is ready to be published.
If any TS error is found, mention me anytime.

peacechen commented 3 years ago

@sugersuger Thanks again for contributing to this project 🎉