search

BugiDev / react-native-calendar-strip

Easy to use and visually stunning calendar component for React Native.
MIT License
944 stars 327 forks source link

Highlight date container style override fix #318

Closed QuintonC closed 3 years ago

QuintonC commented 3 years ago

Fixed issue where the highlightDateContainerStyle was overridden by dayContainerStyle. Also added dayContainerStyle to the list of valid props for the package.

peacechen commented 3 years ago

Thanks @QuintonC for these fixes 👍

Please revert the version bump in package.json. That gets bumped in a separate commit since there may be multiple commits in a release.

QuintonC commented 3 years ago

Thanks @QuintonC for these fixes 👍

Please revert the version bump in package.json. That gets bumped in a separate commit since there may be multiple commits in a release.

Removed version bump.

Let me know if you need anything else or want eyes on another PR. Happy to help out since the project I'm working on will be using this package for the foreseeable future 👍

peacechen commented 3 years ago

Thanks. Submit as many PRs as needed for your usage. Search the issues to see if it also fixes a previously reported bug.

Do you need a new version published immediately?

QuintonC commented 3 years ago

Thanks. Submit as many PRs as needed for your usage. Search the issues to see if it also fixes a previously reported bug.

Do you need a new version published immediately?

I don't need it published immediately. Maybe we can take care of some of the other PRs that are on here and then publish a new version.

Thanks for the merge 🙂

peacechen commented 3 years ago

Published in 2.2.5