search

Bugsacademy / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #5

Open sangjunp4rk opened 7 years ago

sangjunp4rk commented 7 years ago

Summary Grade: Needs Improvements

Good job with your code! I really like the use of whitespace! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Finally, good decision to save images locally! Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Great start to the Ready program!

I included a few notes in both the html can css files for you to think more critically about. The most important thing is to make sure you use relative path instead of absolute. The path you have right now is specific only to your computer so it doesn’t load on others. You should start the directory path from where your index.html file is located. Finally, your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line.

Bugsacademy commented 7 years ago

Thank you for the great feed back!