search

Bugswriter / tuxi

Tuxi is a cli assistant. Get answers of your questions instantly.
GNU General Public License v3.0
1.32k stars 73 forks source link

[Bug] Getting View All instead of no response. #103

Closed Bugswriter closed 3 years ago

Bugswriter commented 3 years ago

image

When I type die noob korean

I get view all.

See the bottom of this SS

image

Why we are getting View All? This should be No result.

PS : I am toxic gamer. I found lot of other country gamer. That's why I was translating die noob (in game)

Genghius commented 3 years ago

image I am unable to replicate the problem. However, i know what is causing the issue. that is the newest change to the translate function. someone made it faster by changing from what i originally wrote to this: image

It is picking up any first child of any span so it also picks up the first child of the span here: image returning "View all". The fix is quite simple, return the translate function to what I wrote originally (It still is quite slow so making it slower wont make much difference eh?).

Genghius commented 3 years ago

btw, we cant just use the class of the span used by the translate div in order to keep the current speed because: image that span has no class. So yes, our only options are to go back to what I had written.

Genghius commented 3 years ago

I fixed this with my PR panacea 3 #107

Genghius commented 3 years ago

yikes, this has been fixed for a while now, can be closed.

Bugswriter commented 3 years ago

Oops .. I forget to close this one.