Panacea 3, I give up! - Githubissues

Bugswriter / tuxi

Tuxi is a cli assistant. Get answers of your questions instantly.

GNU General Public License v3.0

1.32k stars 73 forks source link

Panacea 3, I give up! #107

Closed Genghius closed 3 years ago

Genghius commented 3 years ago

This thing has reached the point where its a snowflake in the middle of a desert, if i touch anything im afraid it'll fall appart. thus I give up on trying fixing any more than this. -Makefile has been reverted, it should have always pointed towards ~/.local not /usr/local considering this is a script. -fixes issue #103 2021-02-19_12-51-37 2021-02-19_12-51-59 ... That is, by reverting the PR that made translate faster And sending rich lists to the bottom of the script... turns out... rich lists are all the world's evil. -From now onwards, all changes in the order of the scraps will need to have an explanation / reason.

Code is getting messy, complex and un-extensible (rich lists being th egreatest contributor to this). I advise for putting every scrap into its own function, getting rid of any scrap that will read more than 1 html element and having much stricter testing on anything added by new PR's.

Genghius commented 3 years ago

This PR accidentally tries to change the README.md file. However, it just brings it to an older version, if this is to be merged, README should be ignored.

Genghius commented 3 years ago

This pr has not been run trough any proper test, and I leave this to yall, caus i truly have no idea what i have done or if it'll work.

Genghius commented 3 years ago

testoutputs.txt my testoutputs.txt file. basic tests.

Bugswriter commented 3 years ago

Our main branch currently is working pretty nicely. The goal is our tuxi should do all the features it offer.
How about .. making a backup of our current develop branch and deleting it? Then start with main again. First we will turn everything into functions .. properly and .. merge it with main. then We will start adding features we have in our current develop branch?

Genghius commented 3 years ago

Our main branch currently is working pretty nicely. The goal is our tuxi should do all the features it offer. How about .. making a backup of our current develop branch and deleting it? Then start with start with main again. First we will turn everything into functions .. properly and .. merge it with main. then We will start adding features we have in our current develop branch?

that seems to be the best option, because everything in develop is messy.

Bugswriter commented 3 years ago

This pr has not been run trough any proper test, and I leave this to yall, caus i truly have no idea what i have done or if it'll work.

I understand the frustration. I also believe this thing is getting too fragile. That's why. I am suggesting to just forget about our current develop branch and start with making functions in new branch fork of main branch and ..TEST THE HELL OUT OF IT.

Genghius commented 3 years ago

This pr has not been run trough any proper test, and I leave this to yall, caus i truly have no idea what i have done or if it'll work.

I understand the frustration. I also believe this thing is getting too fragile. That's why. I am suggesting to just forget about our current develop branch and start with making functions in main branch and ..TEST THE HELL OUT OF IT.

imma do that.

Bugswriter commented 3 years ago

So I created the dev2 branch from main and I think instead of adding new feature first .. lets organize everything which we have. By creating functions we are not altering anything so there is no chance of break (if we do things properly) After this we can test and then look into out messy branch to steal features which are not getting any issues.

Bugswriter commented 3 years ago

imma do that.

Opps I wrote main. don't do anything in main. I made dev2 branch (fork of main)

colonvirus commented 3 years ago

Imma take on documenting all of google's SERPs, their html, and location differences, so other devs can understand how each SERP is scraped, and not just go "hmm yeah that seems cool, add it", which was how we got to this point.

Gonna take a while tho