search

Bugswriter / tuxi

Tuxi is a cli assistant. Get answers of your questions instantly.
GNU General Public License v3.0
1.32k stars 73 forks source link

implement pureartistry's fix, but for main #145

Closed sudocanttype closed 3 years ago

sudocanttype commented 3 years ago

Lmao half (or like 90%) of this code is pureartistry's. Everything is working, the testoutput is attached. I recommend someone else try and make sure this works before merge.
BTW, this code is supposed to be temporary fix for #112 until purert gets into main, so it should be fine for now. testoutputs.txt

BeyondMagic commented 3 years ago

@sudocanttype

There are two translate lines in tuxi, could you remove the duplicate?

https://github.com/Bugswriter/tuxi/blob/dc714749a563be654b89fb0c3e9a4efbc45b1ec0/tuxi#L210-L216

sudocanttype commented 3 years ago

Huh never noticed that, I'll delete it

Bugswriter commented 3 years ago

Wait .. I am getting PR for main.. Also some people are saying merging @PureArtistry -version with main? What's the point of improving main then?

sudocanttype commented 3 years ago

this code is supposed to be temporary fix for #112 until purert gets into main, so it should be fine for now. The PureArtistry version is still being worked on, and I want the bug fixed in main until purert becomes main

sudocanttype commented 3 years ago

@Bugswriter There was a bug that was merged in. The learn to pronounce was not tested at all, and it does not work because it was written with the old way of snipcall. I rewrote it to work and added testcases for it. As of this commit everything in this commit should work. testoutputs.txt

BeyondMagic commented 3 years ago

this is pretty much ready to merge @Bugswriter

Bugswriter commented 3 years ago

I am middle of my exams .. so I am just merging can't test. All up to you soldiers. Tomorrow I will join.

BeyondMagic commented 3 years ago

this didn't change many things, it's working normally good luck in your exams