search

Bugswriter / tuxi

Tuxi is a cli assistant. Get answers of your questions instantly.
GNU General Public License v3.0
1.32k stars 73 forks source link

credit where it's due... #146

Open PureArtistry opened 3 years ago

PureArtistry commented 3 years ago

It looks like my version of the script is about to become the new main and as it's basically a complete re-write of the core logic that necessitated shuffling a lot of the script around...

it's basically only my name in the blame!

This really doesn't seem fair to the many contributors, I haven't spent a second scraping the html for snippets for example.

I'm trying to add credit where I can in comments in the script but I'm not really sure who has contributed what.

So if you want your name in there please let me know where I should add it, thanks!

BeyondMagic commented 3 years ago

I'm trying to add credit where I can in comments in the script but I'm not really sure who has contributed what.

@Bugswriter wrote the scraping of corrections/did_you_mean, also Knowledge Graph, Basic answers, Featured Snippets.; and one class of Rich Answers was made by him.

@karthink added Units and Currency Conversion #44.

sudocanttype commented 3 years ago

Is it ready to be deployed into main? I've run into a couple bugs in testing. How about we commit it to the purert branch, and then we can have a bunch of people test it, not just me. Since it is a gigantic rework of the code, we should be wary of unforeseen bugs.

PureArtistry commented 3 years ago

I didn't necessarily mean it was ready right now just that it seems that was the eventual direction things were heading, sorry if I'm overstepping.

What bugs have you run in to? I can take a look at them now

sudocanttype commented 3 years ago

Ah, I was just saying that we should take things slightly slower. Case in point the develop branch, where we went a little too fast and it blew up, and now no one wants to work in it. Ok first problem, it goes directly to quotes. I'm pretty sure this is unintended image

sudocanttype commented 3 years ago

Lets merge #144, and then I can help hammer out bugs that pop up.

BeyondMagic commented 3 years ago

w

Is the newline after executing the command intentional?

PureArtistry commented 3 years ago

yeah, it's my personal taste, sorry it's the printf on line 4, I left it at the top because I figured that would be removed

It's going to quotes because that processes slightly faster than kno_right the priority variable is kind of a lie because although they are started in that order it basically starts them all simultaneously.

I''ve just tried moving kno_right to the top and it sometimes prints that but often quotes still comes through faster. I'm going to start working on a smart search feature to help fix this.

BeyondMagic commented 3 years ago

That newline makes me uncomfortable lol

PureArtistry commented 3 years ago

I'll get rid of it in the next commit and just add the newline to my prompt instead

Bugswriter commented 3 years ago

Sorry guys I am busy with my exams .. that's what taking so long for me to merge @PureArtistry version with main. But I think the way I get PR and issues .. we need to do this soon. I looked at @PureArtistry code it's a massive upgrade. I want to just merge @PureArtistry version with main just waiting a confirmation from you guys .. that it's ready and I can do this.

BeyondMagic commented 3 years ago

It's not ready yet.

Bugswriter commented 3 years ago

Ok .. the issue is everytime we get a new PR for new feature on main @PureArtistry version lack behind. So I just want to merge ASAP so we can get new update in his version and forget our old code.

terminalforlife commented 3 years ago

I don't see the need to clutter code with unneeded comments; there are plenty enough as it is, from what I've seen in develop. Credit can be given in a man(1) page, on GitHub, or some other form of documentation (IE: Wiki). That's just my preference, though.

BeyondMagic commented 3 years ago

Credit can be given in a man(1) page, on GitHub, or some other form of documentation (IE: Wiki). That's just my preference, though.

I think you're right, adding this type of things in a Wiki would definitely be better, however right now there's really no unneeded comments, it's like two more words at the end of a comment already written.