Bugswriter / tuxi

Tuxi is a cli assistant. Get answers of your questions instantly.
GNU General Public License v3.0
1.33k stars 73 forks source link

Add function to show public holiday result #159

Open KevCui opened 3 years ago

sudocanttype commented 3 years ago

Nice. Can you write some test cases for it and send the testoutputs.txt? Or if you don't want to, I can make a new PR with the testcases.

sudocanttype commented 3 years ago

K I made a pr to your main for testing. @KevCui

KevCui commented 3 years ago

Thanks @sudocanttype 👍

sudocanttype commented 3 years ago

output.txt Proof that it works. If someone else wants to test before we merge in, go for it

sudocanttype commented 3 years ago

@BeyondMagic Can you test this branch and see if it works for you? If it does, i think this is ready to merge

BeyondMagic commented 3 years ago

I think Basic Answers has conflict with Public Holidays, Public Holidays should be put before it.

sudocanttype commented 3 years ago

Can you give me an example of where it conflicts? I need something to test to fix the problem

BeyondMagic commented 3 years ago

try "christmas" with both features

sudocanttype commented 3 years ago

oh yea, i see it

BeyondMagic commented 3 years ago

also, I think we can add a better sed there, like

holiday's name
* holiday's day
holiday's name
* holiday's day
...

or

holiday's name - holiday's day
holiday's name - holiday's day
holiday's name - holiday's day
...
sudocanttype commented 3 years ago

what exactly is ./tuxi christmas supposed to return? are we trying to give the definition?

BeyondMagic commented 3 years ago

I mean, it should, but it's not.

sudocanttype commented 3 years ago

This doesnt seem to be a problem with the public holiday function. Try checking out the main branch of tuxi and trying ./tuxi christmas. For me it still returns the same thing, so something else is messing with it

BeyondMagic commented 3 years ago

Oh yeah, I remember fixing this in develop branch, I thought this would fix this too in the main since the name is for public holidays

sudocanttype commented 3 years ago

How did you fix it in the develop branch?

BeyondMagic commented 3 years ago

by adding -a to see all results, lol