Closed jhagas closed 3 years ago
Nice work. Lets see someone improve your code quality. But before adding anything. I need a proper test response with a variety of questions. Not just two or three at least weather for 20 cities.
Screenshot, i test it with every cities that i know
This is great.
are we ready for merge?
I'm using cut and rev command. While it is working, but i think sed is better. Sadly, i dont understand it (i'm new in linux and shell scripting). Can sed do the exact same stuff?
How my commit work? by pup-ing image line in google html code
pup 'img.wob_tci'
. Then removing some word and letter in that line of code and leaving the "weather condition" phrase inside the image alt info
I'm using cut and rev command. While it is working, but i think sed is better. Sadly, i dont understand it (i'm new in linux and shell scripting). Can sed do the exact same stuff?
How my commit work? by pup-ing image line in google html code
pup 'img.wob_tci'
. Then removing some word and letter in that line of code and leaving the "weather condition" phrase inside the image alt info
@officialcactar ?
111 uses only awk and sed as per author's request. @Bugswriter
@Genghius I think we can merge this PR directly into main.. This is not doing much. also it's well tested?
I am thinking about adding working features safely in main
This pr can be closed now.
@jhagas You did a good job.
It's working but it's greatly inefficient. Can anyone improve it?