Fixes Issue #32, Removes traces of OAuth, unwanted Auth procedures

BugzIO / SprintRPC

@k88hudson's bugzilla app `sprinter` made to work with Bugzilla's JSONRPC instead of REST

0 stars 2 forks source link

Fixes Issue #32, Removes traces of OAuth, unwanted Auth procedures #34

Closed sudheesh001 closed 9 years ago

sudheesh001 commented 9 years ago

Removes test json
Removes usage of a config file .env
Removes fake json values used for testing.
Removes most of github sessions and auth except middleware (blocking insert operations)
Removes unwanted config values and Auth routes from routes/index.js

Signed off by: ssingana@redhat.com

debloper commented 9 years ago

IIRC, the PORT is required for the code to work. You will know that if you delete the .env file before running the server.

Until we fix that (or hardcode the port) this can't be merged. Append/squash-rebase commit.

Please check for regression as well. Set up a fresh new parallel server, cloned from your repo & see if it works (traces from tweaks over the time may make it feel like removing some code will be okay). Although, we probably hitting the threshold of needing a CI system triggered on each PR.

sudheesh001 commented 9 years ago

Already hardcoded. None of the variables in the .env file are being used. I tested first with my .env before working on making the same changes in the .env-dist which I pushed. Looks like now we need to change the documentation too.

https://github.com/debloper/SprintRPC/blob/1ff2df1aad120fce43f40ed862542c1d8d5caf0d/server/app.js#L17-L19

debloper commented 9 years ago

Oh right... I think I did that already! :sweat_smile: