Naim-dev branch suggestions

BuidlGuidl / address-vision

https://address-vision.vercel.app

MIT License

2 stars 4 forks source link

Naim-dev branch suggestions #7

Open ZakGriffith opened 1 year ago

ZakGriffith commented 1 year ago

Good work, really like the clean UI and the ability to add so many chains! Here is what I found in my testing

The icon is overlapping the name of the tokens when the name is long.

The QR code position to the left of the chain selection bar seems off to me. Not sure exactly where that would look better. Maybe centered somewhere?

The NFT lists are more of a secondary feature, but it's taking up half the screen real estate here. Maybe that can be adjusted in order to find a better place for the QR code?

Overall nice work!

ZakGriffith commented 1 year ago

Btw, these aren't changes you have to make, just suggestions based on my usage.

ZakGriffith commented 1 year ago

@Naim-Bijapure

Naim-Bijapure commented 1 year ago

cool , thanks @ZakGriffith let me check where I can manage these changes.

rin-st commented 1 year ago

Copy-paste from tg message

Wrong info about testnets. I have nft's but app tells me that I'm not. testnets.opensea shows the same list for sepolia and goerli btw, not sure if should work like this.
you have select and tabs, so networks info is duplicated. What about something like chrome tabs with "+" sign for choosing next network? (not critical, just to think about it)
nft accordions are bugged a little bit. You can open but can't close it. And page jumps when you open nft collection with height less than already opened.
Also nft's take a lot of space I think better to do it smaller.
"Also available here" is too close to input, it seems like it's input info
When I'm choosing polygon I'm getting this red error

Naim-Bijapure commented 1 year ago

hi @rin-st made a few changes. from your above feedback points not sure about point 1, need to check if covalent supports open sea and testnet etc. have fixed your point 2,3,4,5

for point 6 looks like from your browser it is getting redirected. can you try the same in incognito mode or clear your cache memory :) it's not happening at my side.

ZakGriffith commented 1 year ago

Updates look better!

I a not a fan of the QR code being locked behind the loading bar for a handful of seconds. Is there a way with how you're currently creating that code to have it appear first thing? I assume the gas and NFT count will take some time to load still.

Card spacing is overlapping when viewing very wide.

If this is planned to be used on mobile, some items will need tweaked:

rin-st commented 1 year ago

hi @rin-st made a few changes.

I finally found that message. I remember you answered me but forgot where 😄 . Looks much better!

I a not a fan of the QR code being locked behind the loading bar for a handful of seconds

for me that block loads very slow, like tens of seconds. Currently I'm waiting like 5 mins but it still loads

Naim-Bijapure commented 1 year ago

@ZakGriffith yah it's not mobile optimised.

@rin-st right an account with lots of tax like vitalik, atg it take some time from covalent APIs

I am thinking is covalent is right choice for this kind of build? Let me check it