Add builders list - Githubissues

BuidlGuidl / batch6.buidlguidl.com

https://batch6.buidlguidl.com/

MIT License

3 stars 9 forks source link

Add builders list #19

Closed wildanvin closed 5 months ago

wildanvin commented 5 months ago

Description

I added a list with the builders that have checked in. It displays the builder's address and an icon that takes you to the builder page.

Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

Related Issues

Hopefully it will close issue #3

Your ENS/address: wildanvin.eth

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
batch6-buidlguidl-com-nextjs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 8, 2024 6:54pm

wildanvin commented 5 months ago

Absolutely, I will create the builders page then.

I will suggest updating the nav bar on the home page in order to access the new builders page

technophile-04 commented 5 months ago

I will suggest updating the nav bar on the home page in order to access the new builders page

Ohh yes we should def add it !

Also btw, no need to create a new PR you can revert the changes to home page by doing :

git revert ${commithash} in this this case git revert f689658 this will revert your last commit (that is changes to home page) and then you can create new page.tsx inside app/builders

wildanvin commented 5 months ago

Hello! I was about to ask you about making a new PR hehe... I realized that there are changes merged in the home page regarding the issue #5 "Get the check-in count from the Batch Registry contract". If I do git revert f689658 I won't have those changes and there will be a conflict when trying to merge right?

wildanvin commented 5 months ago

Hmmm... hopefully all is good now...

jriyyya commented 5 months ago

@wildanvin Looks good 🚀, But you forgot the Navbar update

wildanvin commented 5 months ago

@wildanvin Looks good 🚀, But you forgot the Navbar update

you are right! I think i will make that in a different PR

Okhayeeli commented 5 months ago

Great job @wildanvin !!!

technophile-04 commented 5 months ago

Thanks @wildanvin for all the changes !!

you are right! I think i will make that in a different PR

I think it makes sense to add it in this PR itself ? It should be just couple of lines addition in Header.tsx and once we merge this PR, could you easily navigate to builders page instead of manually typing the URL . What do you say?

wildanvin commented 5 months ago

I added the builders page in the navbar. I guess you were right @jriyyya 😅

https://github.com/BuidlGuidl/batch6.buidlguidl.com/assets/48974550/bd915265-61bd-4d9b-9532-df765bdc5f7e

wildanvin commented 5 months ago

Awesome! thanks a lot for the feedback and explanations @technophile-04 !!