Closed edizzum closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
batch7-buidlguidl-com-nextjs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 19, 2024 1:33am |
Hey @edizzum! Thanks for your PR. I love the use of Nietzsche, that's a fun touch. You also make good use of formatting to make the information on the page easier to read. Here are a few pieces of feedback on your PR.
rebase
feature to "pick" the commit you want to keep and "drop" the commit you want to remove. Any search for "how to remove commit from a pull request" will say something similar, such as these answers.Header.tsx
to provide a link to your profile page. The good news is we already have a Builders
button on the app page. In your version everyone would have a link in the Header, which might get crowded quickly. Please remove your changes to Header.tsx
from this PR.yarn build
before committing your changes to catch these kinds of errors. If you can't reproduce the errors locally, let me know and I'll show you the logs I'm seeing, such as NextJS's suggestion to use <Image>
instead of <img>
for performance.Even i said to me Mid-Level Smart Contract Developer, i see myself a Multi-Chain Smart Contract Developer.
Thank you for taking the time to read and incorporate my feedback! Practicing working with git like this is one of the main goals of the Batch 💪
Thanks for taking the time to incorporate my feedback, @edizzum! I really enjoyed reading about the projects you've worked on. Merged!
Description
QuadCores personal page:
Related Issues
8
Your ENS/address: quadcore.eth/0x61F4c9bB022dFF50d213F007E6b5004b54543E3C