BuidlGuidl / batch7.buidlguidl.com

Home base for BuidlGuidl's 7th Batch of Buidlers
https://batch7.buidlguidl.com/
MIT License
4 stars 10 forks source link

#2 Added Personal Page guneriv.eth #26

Closed volkanguneri closed 1 month ago

volkanguneri commented 1 month ago

Description

Issue : 2 Added Personal Page

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address: guneriv.eth

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch7-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 3:55pm
volkanguneri commented 1 month ago

Hi @phipsae ! Thank you very much for all of your advices that i tried to take in considiration and i ve just pushed a last version containing all modifications.

I have just a doubt on icons for portfolio and certificate that i found on the net. i m not sure that they are self-explanatory enouph for user experience. If not, would you have any advise on where to catch good ones?

Thanks again and here my screenshots for both dark and light mode of my new personal page.

personalPageDark PersonalPageLight

phipsae commented 1 month ago

Thanks for implementing all the changes, @volkanguneri!

Great job, it looks great! I appreciate that you're using SVGs for the icons. As a small tip to make your code cleaner, consider creating separate SVG files for the GitHub and LinkedIn symbols. Regarding the term "self-explanatory," I think it's subjective; I find your approach clear. Additionally, you can use libraries like HeroIcons or even emojis for icons.