BuidlGuidl / batch7.buidlguidl.com

Home base for BuidlGuidl's 7th Batch of Buidlers
https://batch7.buidlguidl.com/
MIT License
4 stars 10 forks source link

#5 Get the check-in count from the BatchRegistry contract #28

Closed volkanguneri closed 1 month ago

volkanguneri commented 1 month ago

…e.tsx to render it

Description

Concise description of proposed changes, We recommend using screenshots and videos for better description

I have created BatchTotalCheckInNum component dans app/_components and imported it in app/_components/index.tsx and page.tsx. I ve chosen the red color for more visibility but i can modify it quickly if contested.

002

There is also a loading animation in red by waiting the contract response.

001

Additional Information

Related Issues

Closes #{issue number}

5

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address: guneriv.eth

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch7-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 1:14pm
derrekcoleman commented 1 month ago

Hey Volkan! Thanks so much for your PR. I love your approach of factoring out the check-in component.

For context, @Ursulovic was already assigned to this issue a couple weeks ago. What you might not have known is that he privately asked me if a delay was alright, which I said yes to. In open-source software it's common to have someone "assigned" to an issue to avoid having two people working on a solution at the same time. If you suspect the person assigned is too busy or has forgotten, I encourage you to ask around - sometimes the maintainers would love to reassign, other times it's just OSS being a slow process.

Closing this since #29 already exists.