search

BuidlGuidl / burnerwallet

https://burner.buidlguidl.com
MIT License
0 stars 1 forks source link

refactor: Use EtherInput in Send Drawer #43

Closed ChangoMan closed 2 months ago

ChangoMan commented 2 months ago

Description

Use the EtherInput component in the send drawer. Also added a toFixed(4) to the values that show up in the history list, so that they don't overflow

Screenshot 2024-04-24 at 10 22 20 AM
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
burnerwallet-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 2:18am
Pabl0cks commented 2 months ago

Was about to create a couple of issues for address&quantity validation, but this PR already fixed quantity validation, so just added a valid address validation to avoid this error when clicking "Send" with a invalid address:

image

ChangoMan commented 2 months ago

Looks good to me!

Nitpick: On my windows desktop screen the Ξ symbol looks a bit strange, on mobile looks cool.

image

@Pabl0cks I changed the font for that eth symbol, can you check to see if it's any better now? If not, we might need to use an SVG there.

Pabl0cks commented 2 months ago

@Pabl0cks I changed the font for that eth symbol, can you check to see if it's any better now? If not, we might need to use an SVG there.

I see it great now! Thanks Hunter 🙌

image