search

BuidlGuidl / burnerwallet

https://burner.buidlguidl.com
MIT License
1 stars 1 forks source link

Limit Desktop Container #6

Closed ChangoMan closed 3 months ago

ChangoMan commented 3 months ago

Description

Adds a max width around the whole container, with a border and box shadow, as suggested in https://github.com/BuidlGuidl/burnerwallet/issues/4#issuecomment-2037832306

Happy to iterate on this further if we want something different for Desktop! This look will imply that burner wallet should be used on mobile, which may or may not be desired.

Screenshots

Screenshot 2024-04-05 at 9 20 33 PM
carletex commented 3 months ago

Thanks for this Hunter, and Damu for the review!

Happy to iterate on this further if we want something different for Desktop! This look will imply that burner wallet should be used on mobile, which may or may not be desired.

From #1

As for the desktop view, we can make the wrapper full width no problem! Another option is to make the desktop view "confined" to a mobile layout. https://bracket.game/ is a good example, the desktop view is confined and suggests that it's made for mobile. We could add a border around the layout and change the background color so that it's more "boxed in" like this.

I think we can discuss about this later on too, but with this PR it looks better than before, so good iteration :D

I personally prefer something like (less confined haha) :

image

I think also hints that it should be used on mobile. The thing I like is that if you use it on Desktop you can resize the window as you please (if full screen is too much).

In any case, nothing critical, we can give it a thought later on

Thanks!!

carletex commented 3 months ago

Bracket game feels too narrow... but the burner wallet is wider, which I like way more. I can get used to that haha