BuidlGuidl / burnerwallet

https://burner.buidlguidl.com
MIT License
0 stars 1 forks source link

WalletConnect - Pending TODOs and known issues #60

Open Pabl0cks opened 4 weeks ago

Pabl0cks commented 4 weeks ago

Creating this to continue iterating on WalletConnect integration. Moving pending TODOs and issues from #46.

We can document new issues here too, and iterate with different PRs until is polished.

Features

Visual improvements

Issues

damianmarti commented 3 weeks ago

@Pabl0cks An update on the pending issues.

When I disconnect from the dapp, and connect again, i keep getting "Wrong network" message. It also happens if I connect to a different Challenge, for example: Connect to Chal 0, disconnect. Connect to Chal 5, get "Wrong network" message > Change network to Sepolia in dapp > Disconnect Connect to Chal 0, get the "Wrong network" message again.

Not fixed yet, but I think it's related to a change network event, trying to have it fixed.

If you close the WC modal in the dapp (the one that lets you copy the code), it says "Connected" when you click "Connect Dapp" in the burner, but it doesn't really connect.

Not fixed yet too, but I saw that Metamask when scanning the official WalletConnect modal has the same behavior (tested on Chal 0 and Uniswap), so maybe it's something related to the WalletConnect web3modal...

Pabl0cks commented 2 weeks ago

Thanks for the update Damu!

Regarding the change network event, while testing #68 I found that the multiple confirm of "Change network to.." was happening when trying to perform an action in Uniswap / Blur.

Will add it to the list just to make sure to verify when we fix the network issues.

Pabl0cks commented 2 weeks ago

Regarding the change network event, while testing https://github.com/BuidlGuidl/burnerwallet/pull/68 I found that the multiple confirm of "Change network to.." was happening when trying to perform an action in Uniswap / Blur.

Will add it to the list just to make sure to verify when we fix the network issues.

Closed this sub-task, it is working now with #70 and #71 changes