search

BuidlGuidl / burnerwallet

https://burner.buidlguidl.com
MIT License
0 stars 1 forks source link

fix: Clean Coinbase Wallet QR Scans #67

Closed ChangoMan closed 2 weeks ago

ChangoMan commented 3 weeks ago

Description

While fixing the scan issue for the send drawer, I noticed that scanning my coinbase wallet QR code wasn't working. It seems like they are appending ethereum: to the address.

This PR will strip that out so that coinbase wallet QR codes will work when scanned.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
burnerwallet-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 3:16am
damianmarti commented 3 weeks ago

Oh, I remember this from when we did the Testnet Dropper in Denver last year.

https://github.com/carletex/testnet-dropper/blob/main/packages/nextjs/pages/index.tsx#L143

I don't remember why we had the @ split too, but I guess some wallets add an extra thing? Do you remember @damianmarti ?

Oh, I don't remember why we added this split by @ :-(

damianmarti commented 3 weeks ago

I found the EIP67 standard to use by the format of scanning a QR code, adding the value, gas, and data, maybe we can start implementing the value.

It doesn't mention anything about something with @, so I think we can leave without this split by @.

damianmarti commented 2 weeks ago

@ChangoMan according to EIP67 (https://eips.ethereum.org/EIPS/eip-67) maybe we can split by "?" and we can create an issue to add the value, gas, and data parameters later.

ChangoMan commented 2 weeks ago

@ChangoMan according to EIP67 (https://eips.ethereum.org/EIPS/eip-67) maybe we can split by "?" and we can create an issue to add the value, gas, and data parameters later.

Ok sounds good, got that added!

damianmarti commented 2 weeks ago

@ChangoMan according to EIP67 (https://eips.ethereum.org/EIPS/eip-67) maybe we can split by "?" and we can create an issue to add the value, gas, and data parameters later.

Ok sounds good, got that added!

Thanks!! Merged!