search

BuidlGuidl / burnerwallet

https://burner.buidlguidl.com
MIT License
0 stars 1 forks source link

refactor: Use Radix UI Dialog as the Balance Warning Modal #72

Closed ChangoMan closed 2 weeks ago

ChangoMan commented 2 weeks ago

Description

Replaces the Daisy UI modal with Radix UI's dialog, for the Balance Warning Modal. There seems to be weird UX behaviors when mixing Daisy UI modals with the Drawer component we have.

Since the Drawer component is using Radix dialog under the hood, this should resolve those weird issues.

Testing

To test the drawer and modal together, I am going into nextjs/services/store/store.ts and setting isSendDrawerOpen to be true initially.

When I have a balance, both the send drawer and warning modal will show up. I can interact and close the warning modal and the send drawer stays open. Hopefully this will also fix the issues in https://github.com/BuidlGuidl/burnerwallet/pull/71

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
burnerwallet-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 1:32pm
damianmarti commented 2 weeks ago

Thanks @ChangoMan !!!

Working goood! The only issue is that if you click outside the Warning modal it's closed. Maybe it should only be closed if you click "Close Warning" button.

ChangoMan commented 2 weeks ago

Thanks @ChangoMan !!!

Working goood! The only issue is that if you click outside the Warning modal it's closed. Maybe it should only be closed if you click "Close Warning" button.

Good idea, got that pushed up