Write Initial Rebasing Token Educational Challenge & Tests

BuidlGuidl / eth-tech-tree-challenges

This repository houses the many challenges of the Ethereum Development Tech Tree

MIT License

3 stars 9 forks source link

Write Initial Rebasing Token Educational Challenge & Tests #35

Closed steve0xp closed 2 weeks ago

steve0xp commented 1 month ago

Description

Create Rebasing Token Challenge as per issue #5.

TODO

[x] Create initial RebasingERC20.sol
[x] Debug tests and contract to ensure challenge works
[x] Create initial RebasingERC20.t.sol tests (pseudo-code)
[x] Add any more relevant tests, I think I'm missing just some on events and whatnot.
[x] Write README sections
[x] Resolve PR Review Change Requests - notably: rounding error tests, and README / natspec updates.

Related Issues

Closes #5

Your ENS/address: steve0xp.eth

steve0xp commented 3 weeks ago

Update Since Last Submission

Created most of the tests for the challenge
Researched, Iterated (upon feedback and research) on challenge scope, Redesigned challenge code
Updated README
Now submitting this for first PR Review to get more detailed feedback on direction, implementation, and thoughts on remaining tests (specifically how to go about the rounding error test(s)).

Remaining Work

[x] Resolve PR CRs once @escottalexander has a chance to provide a PR review.
- [x] Finish off remaining tests (rounding error test, and transferAllFrom after rebase test)
- [ ] Update README to align with code challenge nat spec for rounding errors

steve0xp commented 2 weeks ago

@escottalexander thanks for your reviews! I've responded to your comments and made changes to the code accordingly. It should be ready to review again and hopefully we can merge it to the repo soon :)

steve0xp commented 2 weeks ago

@escottalexander changes have been made. Thanks again for all of your help and these reviews!