search

BuidlGuidl / grants.buidlguidl.com

https://grants-bg.vercel.app
MIT License
3 stars 3 forks source link

Fix rounding problems when batch approving #128

Closed Pabl0cks closed 4 months ago

Pabl0cks commented 4 months ago

Description

Not sure if this is the right way to fix the rounding problems that made Split function not be able to work properly.

Problem was with rounding of totalAmountand then value as described in https://github.com/BuidlGuidl/grants.buidlguidl.com/issues/126#issue-2379255612

Making sure they are BigInt seems to solve the rounding problem.

Fixes #126

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 0:18am
technophile-04 commented 4 months ago

Ohh shit miss this PR, will review it tomorrow for sure thanks!!