Closed Pabl0cks closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
grants-bg | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2024 10:39am |
Hey Pablo, could you also please update :
to <ThemeProvider enableSystem={false} defaultTheme="light">
Because if not, it will launch the website in dark mode if the users system
theme is dark, lol sorry of commenting while the PR is in draft, just came to my mind and I didn't wanted to forget it 🙌
Because if not, it will launch the website in dark mode if the users system theme is dark, lol sorry of commenting while the PR is in draft, just came to my mind and I didn't wanted to forget it 🙌
TYSM Shiv!! I'd probably missed that one, because it was loading on Light to me after testing other branch 🙌
Batch 1 haven't received grant yet, right? I can mark them as "status": "approved" for now.
Yes! Let's do this (so we have data for WIP grants)
@technophile-04 going back for a bit to the dark mode disabling, for some reason in my laptop I had localstorage "theme" set as "dark" (first time loading grants, and OS set to light), and it wouldn't change to "light" refreshing.
Doing some tests:
forcedTheme="light"
works for me.enableSystem={false}
.
In that case if I use forcedTheme
it ignores my system and sets that theme (even if localstorage stays as system)Should we temporary use forcedTheme="light"
to prevent cases like this, until we implement "dark" mode and set everything back to normal? Or should we dig more into this issue.
TYSM
If I use
forcedTheme="light"
works for me.
Ohh yes !! This makes sense , Lets do it for now until we have proper dark theme, Tsym 🙌
Ohh yes !! This makes sense , Lets do it for now until we have proper dark theme, Tsym 🙌
Ok great! Pushed this change.
Yes! Let's do this (so we have data for WIP grants)
Done!
Thanks @Pabl0cks !
Left a few comments and open questions!
TYSM for the review! Just pushed the changes to fix the comments, hope I didn't miss any! 🙌
Thanks all!
Made some tweaks before merging:
(Feel free to tweak for local testing)
f003c09ff80579915ff63e7084a060df98a5ba04
90538e85e8d3c5911c51e33063a616ada0f66e19
Load initial data for grants, grabbing the final projects completed from Batches 0 and 1.
Data questions:
"status": "approved"
for now.Not related but also hided the dark mode toggle button until we implement dark mode.
Closes #29 Closes #30