search

BuidlGuidl / grants.buidlguidl.com

https://grants-bg.vercel.app
MIT License
3 stars 3 forks source link

Reduced view for completed grants at Homepage + completed-grants page for full view #53

Closed Pabl0cks closed 8 months ago

Pabl0cks commented 8 months ago

Description

Creating this new PR because we reverted the changes of the failed (by myself 😅) Squash&Merge.

Also will add the limit to firebase load from homepage.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 0:00am
Pabl0cks commented 8 months ago

Sorry for asking for a new review 😅

Just thought came to mind, In very late future we could handle this in backend too using firebase limit so that we only query 8 documents on home page....but lol not all required now !

Added this suggestion from the old PR in https://github.com/BuidlGuidl/grants.buidlguidl.com/pull/53/commits/3ebcab8a5d6681b60e3ec58d08e86ae8a2928398

With this change we've lost the (#number) in "See all completed grants", didn't want to add it to the function because I'm not sure if it would make it load all the completed grants info, so we'd lose all the load optimization from this.

Not sure if the (#number) adds a lot of value anyways (we have total grants and active grants in stats that already gives an idea of the size of this project to the final user)