BuidlGuidl / grants.buidlguidl.com

https://grants-bg.vercel.app
MIT License
3 stars 3 forks source link

Add contract's txn hash for batch actions #65

Closed technophile-04 closed 8 months ago

technophile-04 commented 8 months ago

Description

Used splitEqualETH function from the contract. In future we could add an unequal spilt function but since in mock DB the askAmount is same for all grant 0.25 it works nicely 🙌

probably Closes #56 ?

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:41am
carletex commented 8 months ago

This is great @technophile-04

In future we could add an unequal spilt function but since in mock DB the askAmount is same for all grant 0.25 it works nicely 🙌

You are right. I pushed this: https://github.com/BuidlGuidl/grants.buidlguidl.com/pull/65/commits/2230038c5c06f3c7da23ed5b4f7d730705124b6f to add a single splitETH function where you can specify a given amount for each address. I think this is more generic and better. Could you tweak the frontend to use this new function? Sorry!


I think we should also call the contract when sending to a single user (send 50%), even if we are not splitting anything:

If we want to optimize gas, I guess we should create a new function for a single address... but let's use splitETH for now.