search

BuidlGuidl / grants.buidlguidl.com

https://grants-bg.vercel.app
MIT License
3 stars 3 forks source link

Store `chainId` for the given grants #69

Closed Pabl0cks closed 8 months ago

Pabl0cks commented 8 months ago

Maybe we can start by doing it hardcoded right now.

In the future we can add the logic to select in which chain you want to send the grant (Optimism / Mainnet), and store chainId according to it.

technophile-04 commented 8 months ago

Just created #72, but was thinking about future workflow :

Currently in #72 we are allowing admin to submit approvedTx hash and completedTx hash to be of different chainId.

I think maybe we should guard completeTx to be only updated if chainId passed while making is equal to completedTx chainId check (https://github.com/BuidlGuidl/grants.buidlguidl.com/pull/72/commits/e11d7769b5afee2380cb95e150333c1118641d16).

Thinking about flow:

Assumption:

We will be deploying same contract (name + abi) on all chains.

Flow:

We have two section on Admin page 1.Mark approved section. 2.Mark completed section,

  1. Mark approved section: All the cards that are yet to be approved will be showed on this section irrespective of admin connected chainId (We are already doing that)

  2. Mark completed section: Here will add two filters,

    1. Show grants that are approved and need to marked completed (We are already doing it)
    2. plus pass it through extra filter to show only grants that are approved on the chainId that admin is connected to.

Lol not sure if it makes sense but would love to know what you guys think / had in mind 🙌

technophile-04 commented 8 months ago

Completed at #72