refactor: Move admin comments into drawer

BuidlGuidl / hackathon-starter-kit

https://extensions-hackathon.vercel.app

MIT License

6 stars 1 forks source link

refactor: Move admin comments into drawer #64

Closed ChangoMan closed 1 month ago

ChangoMan commented 2 months ago

Description

I'm thinking about moving the comments into a drawer, instead of using the collapse, so there's less animation and jank when adding or viewing the comments. Let me know how you all feel about this approach!

Screenshot

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
extensions-hackathon	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 26, 2024 3:19pm

carletex commented 1 month ago

I like it!

Could you resolve conflicts? (getFormattedDateTime doesn't exist anymore in the file since you move it in the inner component, but Damu uses it on #61)

ChangoMan commented 1 month ago

@carletex Merge conflicts should be resolved!

carletex commented 1 month ago

(nitpick for future PR: even if you can close the drawer by clicking outside, maybe we could also have a X on the top right of the drawer) @ChangoMan