search

BuidlGuidl / hackathon-starter-kit

https://extensions-hackathon.vercel.app
MIT License
6 stars 1 forks source link

Check for submissionsEnabled on Submit page #85

Closed damianmarti closed 1 month ago

damianmarti commented 1 month ago

It was showing the Submit form (the API endpoint is already checking if the submissions are enabled).

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
extensions-hackathon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 2:08pm
damianmarti commented 1 month ago

Nice catch Damu! ♥

Not sure why I implemented the submissionsEnabled check in the SubmitButton component, I think it's better your approach to not show the submission form, since it can have innacurate data from other hackathons🙏

Should we delete the submissionsEnabled logic from the button since it shouldn't be needed anymore?

Nitpick: pushed a styling change to have the same style of /admin "Access Denied" msg.

Removed the submissionsEnabled logic from the button!

Thanks!!

Pabl0cks commented 1 month ago

Removed the submissionsEnabled logic from the button!

Great! Merging 🙏